search

Skretzo / shortest-path

Pathfinding for Old School RuneScape
BSD 2-Clause "Simplified" License
14 stars 27 forks source link

Feature Request: Add destination text above all teleportation start locations #49

Closed Intecpsp closed 6 months ago

Intecpsp commented 1 year ago

This has recently been done for Fairy Rings, this is just a request to add this feature to any teleportation methods going forward (Spirit Tree, Gnome Gliders, etc.)

SpecialMike commented 6 months ago

@Skretzo I've done a quick proof-of-concept by refactoring how the fairy ring codes are rendered to allow for all transports to render some help text. I'm using the previously unused Notes column in the data files, which works great for spirit trees, and a bunch of other transports, but some definitely weren't meant to be user-facing. Should this data be a new column separate from the Notes column?

Here's a screenshot for a spirit tree: image

Skretzo commented 6 months ago

The data in the Notes column that does not look like it is meant to be user-facing is a remnant of the original creator of this plugin and was probably meant as a future to-do. Those notes are currently not needed so I think I will remove them and rename the column to Info.

Does the fairy ring code show up the same way as it used to?

SpecialMike commented 6 months ago

Yes, fairy rings still show the same way.

I'll update the data files to use Info instead of Notes, and clear out any that won't make sense to draw on the transport. I wanted to get gnome gliders and spirit trees working before submitting a PR.

Skretzo commented 6 months ago

I'm actually working on the rename right now, but I will probably have to leave some of them unfinished as I don't have P2P to test chat box options

Skretzo commented 6 months ago

This was added in version 1.12.2 for spirit trees, gnome gliders, charter ships and canoes, and can be expanded to other transports in the future.