Skretzo / shortest-path

Pathfinding for Old School RuneScape
BSD 2-Clause "Simplified" License
14 stars 27 forks source link

Question on source of shortcut information #54

Open mikeweyandt opened 9 months ago

mikeweyandt commented 9 months ago

Any thoughts or attempts made in the past on updating runelites view of these shortcuts/etc, and then using those as the source?

As an example to what I mean, updating the data in https://github.com/runelite/runelite/blob/master/runelite-client/src/main/java/net/runelite/client/game/AgilityShortcut.java and https://github.com/runelite/runelite/blob/master/runelite-client/src/main/java/net/runelite/client/plugins/fairyring/FairyRings.java to include what's needed for this plugin.

Just feels a little redundant going through and replicating a lot of that data.

Skretzo commented 9 months ago

I do agree that it feels redundant to replicate a lot of this data, but I also store necessary metadata information about these shortcuts that I am not sure RuneLite would want to include, e.g. associated quest/diary requirements, level requirements, item/money requirements and travel duration (e.g. time spent in a cutscene). Core RuneLite development is almost exclusively bug fixes these days and is not interested in catering to hub plugin developement.