New features from 1.13

[Nicofisi]

I tried to list all the new features in 1.13 that are relevant for Skript

Many new items/blocks

Out of scope of the issue, need to be taken care of in skript-aliases (useful link - here)

New biomes

• [x] minecraft:small_end_islands
• [x] minecraft:end_midlands
• [x] minecraft:end_highlands
• [x] minecraft:end_barrens
• [x] minecraft:warm_ocean
• [x] minecraft:lukewarm_ocean
• [x] minecraft:cold_ocean
• [x] minecraft:deep_warm_ocean
• [x] minecraft:deep_lukewarm_ocean
• [x] minecraft:deep_cold_ocean
• [x] minecraft:deep_frozen_ocean
• [x] minecraft:frozen_ocean

New enchantments

• [x] Channeling
• [x] Impaling
• [x] Loyalty
• [x] Riptide

New particles

• [x] minecraft:bubble_column_up
• [x] minecraft:bubble_pop
• [x] minecraft:current_down
• [x] minecraft:squid_ink
• [x] minecraft:dolphin
• [x] minecraft:nautlius

New status effects

• [x] Conduit Power
• [x] Dolphin's Grace
• [x] Slow Falling

New entities

• [x] Dolphin
• [x] Drowned
• [x] Phantom
• [x] Cod
• [x] PufferFish
• [x] Salmon
• [x] TropicalFish
• [x] Turtle
• [x] Trident

Tags

• [ ] Some support for checking whether something is tagged with some tag could be added, not sure about modifying them though - related link

New things in the Bukkit API

Added after 1.12

• [ ] Entity.getPistonMoveReaction()
• [x] BroadcastMessageEvent extends ServerEvent implements Cancellable
  • [x] getMessage(), setMessage(value)
  • [x] getRecipients(), sometimes modifiable, sometimes not?
• [x] PlayerPickupItemEvent (which Skript uses) deprecated in favor of the new EntityPickupItemEvent (we should probably support both?)

  Added after 1.12.2

• [x] Creeper
  • [x] getMaxFuseTicks()I, setMaxFuseTicks(I)
  • [x] getExplosionRadius()I, setExplosionRadius(I)
• Score#isScoreSet()Z although Skript has no scoreboard support at the moment
• [x] PlayerItemMendEvent extends PlayerEvent implements Cancellable
  • [x] getPlayer()Player
  • [x] getItem()ItemStack
  • [x] getExperienceOrb()ExperienceOrb
  • [x] getRepairAmount()I, setRepairAmount(I)
• [x] Player#hidePlayer and Player.showPlayer were interestingly improved - handled by @Blueyescat
• [ ] Villager
  • [ ] getCareer()Career, setCareer(Career)
  • [ ] setCareer(Career, boolean resetTrades) - more info
• New methods in CreatureSpawner but Skript doesn't have any spawner support afaik
• AbstractHorse#getInventory()AbstractHorseInventory probably unimportant though
• [ ] New methods in EnderSignal
• [x] Slime - getTarget()LivingEntity, setTarget(LivingEntity)
• [ ] Arrow - isInBlock()Z, getAttachedBlock()Block - arrows in a block are motionless and may be picked up by players

  Added in 1.13

• [x] Entity - isSwimming()Z, setSwimming(Z)
• [x] EntityToggleSwimEvent extends EntityEvent implements Cancellable
  • [x] getEntity()Entity
  • [x] isSwimming()Z
• all the other additions listed before in this issue

Other (not really related)

• 4 new advancements, but Skript doesn't have advancemenet support
• new sounds
• new statistic used by phantoms (time_since_rest)

[TheBentoBox]

I did already have something like this in #751, but yours is much newer and less cluttered with technical stuff/details so I think we can swap to using your list here. Can you just add the new entities as well? Those being Dolphins, Drowned, Phantom, Turtle, Cod, Salmon, Pufferfish, and Tropical Fish.

Also on the note of the new entities, as described in dev22g's release there are some entity supertypes. I'm not sure if there's a supertype for zombies (it's not listed there), but if there isn't one it should be added and the new Drowned mobs should be a part of it. There should also be a fish supertype for the four fish mobs that exist now.

[TheBentoBox]

Also, entity swim state API and swim toggle event. Should be supported just like elytra glide states.

[TheBentoBox]

Closed #751 in favor of this now. Setting to high priority as 1.13 is very close. Aliases rework first, then this stuff immediately.

[bensku]

Opened another branch for immediate "get it running" issue.

[TheLimeGlass]

Player#hidePlayer and Player.showPlayer is already added in Skript by @Blueyescat if it was changed and it's not already supported it should be modified in the 1.13 branch blue.

Only thing that was changed in the EnderSignal was the despawn timer.

Status effect as in Potion effect?

And finally they added isInWater/isSwimming it's been a method in NMS for a long time and very easy to add, I never understood why they never added it.

[Blueyescat]

@TheLimeGlass I knew that and already added support for the new methods (added in 1.12.2, not 1.13). So no problem 🙂 https://github.com/SkriptLang/Skript/blob/60279c009858a24139fdd35319fd6672853d0f0a/src/main/java/ch/njol/skript/effects/EffPlayerVisibility.java#L86

[ShaneBeee]

hey @Nicofisi I was skimming thru the Spigot API and saw a couple more particles for you to add to your list Particle DOLPHIN Particle NAUTILUS https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Particle.html#NAUTILUS

[TheBentoBox]

I've added them to the post just now, thanks @ShaneBeee , good catch

[Misio12320]

What's the status of work? Just a question.

[ShaneBeee]

What's the status of work? Just a question.

What exactly are you wanting to know? And why exactly are you worried about this?

There is not ETA and/or timeline for the issues mentioned in this thread. Things will get done when they get done.

If you wish to see that checklist get finished, you are more than welcome to do some PRs to contribute to the things that need to get done.

[APickledWalrus]

What's left in this is no longer of high priority. However, these features would still be nice to have. PRs welcome 🎉

EDIT: Probably going to implement the mending feature myself very soon.

[TheLimeGlass]

All that's left are entity/block suggestions. Which an addon like Khoryl focuses on because exact entity types have to be determined at runtime, something that's not logical for Skript erroring and requires janky runtime erroring. Potential close on this?

[TheLimeGlass]

Closable after https://github.com/SkriptLang/Skript/pull/5617, entities are not currently supported in Skript due to runtime limitations.