search

SkriptLang / Skript

Skript is a Spigot plugin which allows server admins to customize their server easily, but without the hassle of programming a plugin or asking/paying someone to program a plugin for them.
https://docs.skriptlang.org
GNU General Public License v3.0
1.08k stars 373 forks source link

Bensku edit takes 7mins 32 seconds to load my scripts. Nfell's 3mins and 23seconds #166

Closed whoshenry closed 6 years ago

whoshenry commented 8 years ago

Why does the Bensku fork take twice as long to load the scripts on startup?

bensku commented 8 years ago

Wow. There is something wrong with the parser.

I guess it is related to function signature pre-parsing... Time to optimize that :)

whoshenry commented 8 years ago

Great, thank you!

whoshenry commented 8 years ago

Any update on the parsing issue?

bensku commented 8 years ago

No idea how long this takes. I basically need to rewrite quite a lot code and test it - meanwhile, there are more or less critical bugs waiting fixes.

TrademarkTM commented 8 years ago

Hey Bensku! I'm having the same problem. And yes, I'm using some addons, but it loads faster with nfell's one. Here's an example of Skript that takes a long time to load (but others 10x bigger take less time):

Hastebin link: http://hastebin.com/avukedoqom.vbs

ZeTioZ commented 8 years ago

Hello, I got the same issues and it seem the particles showing make the skript load very slower than other without it

bensku commented 8 years ago

Wow, if that is truly the cause... I have really not even idea how to fix it. Particle system is buggy, but slow? It should't be.

ZeTioZ commented 8 years ago

If you want I can make a little video to show you when I remove the part of code with the particles how slower it load and when I add them how faster it load.

bensku commented 8 years ago

No need, I trust that is the case. I just wonder, how it is so... I fear particle system has some fundamental flaws which would require a rewrite of it - again.

I'll keep you updated when I have new information. No ETA since I have no idea what I'm dealing with.

ZeTioZ commented 8 years ago

Ok thanks

bensku commented 8 years ago

@ZeTioZ Multithreaded parser coming in next update. I also indeed found one very stupid mistake I had made when working with current script loader.

ZeTioZ commented 8 years ago

So, @bensku you think you got the solution for this problem ?

bensku commented 8 years ago

Probably. And if not, multithreaded parser is so much faster anyway...

whoshenry commented 7 years ago

Just an update, the Skript is still taking a long time to load everything. With dev24b.

Tristag commented 7 years ago

Hey, I'm also having this issue. It takes almost twice as long to start up :( Not to just whine about it though, awesome job you've been doing so far! I'm just salty I can't get your awesome built in json!

I know its probably not this simple, however what if you were to look at nfell's fork and see how the parser works there?

Thanks again for your work!

bensku commented 7 years ago

I might have a hunch what causes this, but no promises.

Tristag commented 7 years ago

No problem, it seems like its particle/sound related, if that helps?

TheBentoBox commented 6 years ago

There are far newer issues related to slow script load times.