Prevent scripts from crashing server

SkriptLang / Skript

Skript is a Spigot plugin which allows server admins to customize their server easily, but without the hassle of programming a plugin or asking/paying someone to program a plugin for them.

https://docs.skriptlang.org

GNU General Public License v3.0

1.07k stars 369 forks source link

Prevent scripts from crashing server #1749

Open KleeSup opened 5 years ago

KleeSup commented 5 years ago

Hey Guys! I have a problem with a "while player is online"! If I used that in my Code I get an big Error in console! Error: https://pastebin.com/XwdV1tm8

Server Version: Spigot 1.12.2 Skript Version: Skript 2.3-beta4

Please Help!

TheBentoBox commented 5 years ago

Edited with a better-formatted paste.

Not sure exactly what this is, seems like something with getting the item meta in the %item% with lore expression? Maybe some better sanity checking or version safety is needed.

Snow-Pyon commented 5 years ago

Well, if the guy used the while loop without a delay, it could have probably crashed the server. We may have to warn users about this if possible.

bensku commented 5 years ago

It shouldn't be possible to hang server with scripts. Even right now, there is some code preventing it.

Pikachu920 commented 5 years ago

There isn't, it is definitely possible

bensku commented 5 years ago

My mistake. Skript tries to catch stack overflows from scripts and reports them.

I'd say this is not a bug. If we had safety measures that were not working, we should fix them. But as things are, we might just add them at some point.