search

SkriptLang / Skript

Skript is a Spigot plugin which allows server admins to customize their server easily, but without the hassle of programming a plugin or asking/paying someone to program a plugin for them.
https://docs.skriptlang.org
GNU General Public License v3.0
1.05k stars 365 forks source link

Item's lore and name can't be set in 'on craft' #1929

Open Efnilite opened 5 years ago

Efnilite commented 5 years ago

Description In the 'on craft' event, an item's lore and name can't be changed, even after waiting a tick.

Steps to reproduce

on craft of any pickaxe:
    set name of item to "<light blue>Pickaxe (0)"

Expected Behavior The name and lore of the item will be set after the event.

Server version/platform: Paper-1596 (MC: 1.12.2) Skript version: 2.3.5 Addons: skript-mirror 1.0.0, skript-yaml 1.2.5

Additional context Note that the 'steps to reproduce' code only works on localhost servers. I tested it on a localhost server and it worked (with the same addons, Skript version, etc.), but then I tested it on a bungee connected server, and it didn't work.

Efnilite commented 5 years ago

This still doesn't work with 2.3.6 fyi

Beaness commented 5 years ago

I think skripts work the same on connected bungeecord and localhost servers.

Efnilite commented 5 years ago

I think skripts work the same on connected bungeecord and localhost servers.

After testing it again, this appears to be so. On the localhost server 2019-03-07_15 29 39 On the bungee server 2019-03-07_15 30 47 But still, that isn't the issue.

Efnilite commented 5 years ago

Don't really like to bump stuff on github, but it's been 7 days lol

Runakai1 commented 5 years ago

It actually works if you replace item with "event-slot" does not work with shift clicking. I have tested it on my 1.13.2 paper 2.3.6 skript server

set name of event-slot to "SWORDY" set line 1 of lore of event-slot to "&7Schaden: " set line 2 of lore of event-slot to "&c1" set line 4 of lore of event-slot to "&7Haltbarkeit: " set line 5 of lore of event-slot to "&c100"

f50a36ec-e85e-45c8-a959-11ea48c6db68

Efnilite commented 5 years ago

It actually works if you replace item with "event-slot" does not work with shift clicking. I have tested it on my 1.13.2 paper 2.3.6 skript server

set name of event-slot to "SWORDY" set line 1 of lore of event-slot to "&7Schaden: " set line 2 of lore of event-slot to "&c1" set line 4 of lore of event-slot to "&7Haltbarkeit: " set line 5 of lore of event-slot to "&c100"

f50a36ec-e85e-45c8-a959-11ea48c6db68

Yeah but it should still work with shift clicking..

Blueyescat commented 5 years ago

enhancement, lowest

TheBentoBox commented 5 years ago

This does seem to be an enhancement over a bug, needs manual fix due to how Bukkit API handles the items in craft item events.

MadPanCake commented 1 year ago

Could the issue be fixed anytime soon?