search

SkriptLang / Skript

Skript is a Spigot plugin which allows server admins to customize their server easily, but without the hassle of programming a plugin or asking/paying someone to program a plugin for them.
https://docs.skriptlang.org
GNU General Public License v3.0
1.03k stars 362 forks source link

Support inventory material aliases in multiple non inventory material aliases #5586

Open TheLimeGlass opened 1 year ago

TheLimeGlass commented 1 year ago

Suggestion

There is currently an issue where oak sign would pick either a oak wall sign or a oak floor sign. If it picks the oak wall sign, no item will be displayed in the inventory as a wall sign cannot be displayed in an inventory. This is not an aliases issue as oak sign should represent either oak floor or oak wall signs for proper comparison of block types.

We should implement some sorta system to allow oak sign to always use the oak floor sign in a gui.

Why?

The item isn't displaying in the inventories

Other

Work arounds are instead of defining oak sign use oak floor sign when adding to the inventory.

Agreement

Fusezion commented 1 month ago

Thinking about making a mock of a test fix/change for this but I'm not sure what's the best way to do so, as I can't just rip them out of getRandom and getAll as they still have uses to exist inside it, would it be better to add some addition method and if so what would the name even be?

APickledWalrus commented 1 month ago

some sort of getRandomItem might suffice