SkriptLang / Skript

Skript is a Spigot plugin which allows server admins to customize their server easily, but without the hassle of programming a plugin or asking/paying someone to program a plugin for them.
https://docs.skriptlang.org
GNU General Public License v3.0
1.07k stars 369 forks source link

Include hanging signs in line change event #5778

Open ILikeOrangeJuice opened 1 year ago

ILikeOrangeJuice commented 1 year ago

Suggestion

Currently it is not possible to change the sign content of a hanging sign, neither side is affected.

This is the code I use since a while and it works just fine on regular signs, no matter if attached to a wall or not. https://pastebin.com/wJQSFaWj

Here is also a little preview that it is not affecting hanging signs. https://www.youtube.com/watch?v=qGMXEntCsXM

Why?

Because hanging signs are probably going to be used quite often now and it would make sense to include them.

Other

I use Paper 1.20.1 47, I noticed however that in 51 they added Add an (new?) event for player editing sign , which could maybe be implemented for the hanging signs then in skript? I use Skript 2.6.4

Agreement

TheLimeGlass commented 1 year ago

Hanging sign Aliases for 1.20 are ready for next release.

As for the lines expression, it should be working, unless hanging signs has a different class.

Fusezion commented 1 year ago

Hanging sign Aliases for 1.20 are ready for next release.

As for the lines expression, it should be working, unless hanging signs has a different class.

We might need to check for front/back sides now

EDIT: just tested on beta3 and a 1.20.1 server on sign change and event-strings return properly tested on hanging and normal front and back image

ILikeOrangeJuice commented 1 year ago

Would a hanging sign then change both sides with the provided example or just the one it is being faced? Speaking of set line 1 of target block

Fusezion commented 1 year ago

Oh set line, yeah we need to add front/back support for then I believe, skbee has an expression for this using skript's current system it just silently fails Link to skbee's expression https://skripthub.net/docs/?id=8103