Change Skript#getExpressions to return a collection instead of an iterator

SkriptLang / Skript

Skript is a Spigot plugin which allows server admins to customize their server easily, but without the hassle of programming a plugin or asking/paying someone to program a plugin for them.

https://docs.skriptlang.org

GNU General Public License v3.0

1.06k stars 370 forks source link

Change Skript#getExpressions to return a collection instead of an iterator #6175

Open Fusezion opened 11 months ago

Fusezion commented 11 months ago

Suggestion

Change Skript#getExpressons() from returning an Iterator to a Collection

Why?

All other Skript#get... methods return a collection and while this is a small and minor change it doesn't make sense to have this be an odd one out if non of the other 4+ methods did this,

Other

No response

Agreement

[X] I have read the guidelines above and affirm I am following them with this suggestion.

APickledWalrus commented 11 months ago

This is (or should be) handled in #5331

Fusezion commented 1 month ago

Is this still being handled to a degree in #6246 with the closing of original pr?

APickledWalrus commented 1 month ago

It is handled in that PR, I'll have to make note