SkriptLang / Skript

Skript is a Spigot plugin which allows server admins to customize their server easily, but without the hassle of programming a plugin or asking/paying someone to program a plugin for them.
https://docs.skriptlang.org
GNU General Public License v3.0
1.05k stars 365 forks source link

Have ExprPlayerProtocolVersion Work with ViaVersion #6318

Open NotSoDelayed opened 8 months ago

NotSoDelayed commented 8 months ago

Suggestion

Have ExprPlayerProtocolVersion work with ViaVersion.

Why?

The current implementation uses Bukkit’s and it will always return the protocol version the server is running, which is logical as your Minecraft version must be the same as the server version, if ViaVersion is not installed. We all know that ViaVersion is widely used across many servers to allow older / newer Minecraft versions to join. I had plans to make a PR for this, but just unsure whether the SkriptLang team is fine to have another softdepend plugin into the build script.

Other

No response

Agreement

NotSoDelayed commented 1 month ago

Note PR available #6616