search

SkriptLang / Skript

Skript is a Spigot plugin which allows server admins to customize their server easily, but without the hassle of programming a plugin or asking/paying someone to program a plugin for them.
https://docs.skriptlang.org
GNU General Public License v3.0
1.06k stars 368 forks source link

Add delete changer to ExprMessage #6828

Closed Phill310 closed 3 months ago

Phill310 commented 3 months ago

Description

Adds the delete changer to message expression (so you can do stuff like clear death message)

Target Minecraft Versions: any Requirements: none Related Issues: #5919

Phill310 commented 3 months ago

Are there already tests for this because I can't seem to find them? Also I am not fully sure how I would trigger an event like join to test this

sovdeeth commented 3 months ago

Are there already tests for this because I can't seem to find them? Also I am not fully sure how I would trigger an event like join to test this

It'd need something like a JUnit where you manually call a message event

Phill310 commented 3 months ago

Is 1 test for set and clear good enough or should I try to make a test for each event

sovdeeth commented 3 months ago

Is 1 test for set and clear good enough or should I try to make a test for each event

I think this is fine, but if you're willing, it can't hurt.