SkriptLang / Skript

Skript is a Spigot plugin which allows server admins to customize their server easily, but without the hassle of programming a plugin or asking/paying someone to program a plugin for them.
https://docs.skriptlang.org
GNU General Public License v3.0
1.07k stars 369 forks source link

Manipulating Display Entities via Effect Command Bug #7187

Open aaaeeeMC opened 1 week ago

aaaeeeMC commented 1 week ago

Skript/Server Version

[10:11:33 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[10:11:33 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[10:11:33 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[10:11:33 INFO]: [Skript] Server Version: 1.21-109-5a5035b (MC: 1.21)
[10:11:33 INFO]: [Skript] Skript Version: 2.10.0-beta1 (skriptlang-github)
[10:11:33 INFO]: [Skript] Installed Skript Addons:
[10:11:33 INFO]: [Skript]  - SkBee v3.5.8 (https://github.com/ShaneBeee/SkBee)
[10:11:33 INFO]: [Skript] Installed dependencies: None

Bug Description

I was trying to see how quaternions work, by spawning in a block display, but it didn't work when I tried to change something. Look in the Errors or Screenshots section.

Expected Behavior

It was obviously supposed to change the specific property to what I put, but it didn't work and instead threw an unspecified error.

Steps to Reproduce

  1. Run !spawn a block display at me ("of (block data)" doesn't work by the way)
  2. Make sure the block display is the nearest block display to you for the next steps.
  3. Run !set transformation translation of nearest block display to vector(-0.5,-0.5,-0.5)
  4. You get an unspecified error.
  5. Furthermore, try !set left transformation rotation of nearest block display to vector(1,0,0,0)
  6. Now say "He was right. Time to fix it, I guess." 😭

Errors or Screenshots

Screenshot 2024-11-03 101000

Other

No response

Agreement

Romitou commented 1 week ago

Can replicate, the example provided in the PR #5601 doesn't seem to work when parsing display syntaxes. However, a workaround is to define a local display variable before using it.

TheBentoBox commented 1 week ago

Can confirm (for the dev team - this is the bug I discussed with you in dev chat).

This happens with any expression which resolves to an entity. For example, when using a spawn section to spawn a display, referencing the spawned entity using the entity expression does not work for display syntaxes.

sovdeeth commented 1 week ago

sounds like maybe we need an entity -> display converter