search

SkriptLang / Skript

Skript is a Spigot plugin which allows server admins to customize their server easily, but without the hassle of programming a plugin or asking/paying someone to program a plugin for them.
https://docs.skriptlang.org
GNU General Public License v3.0
1.08k stars 373 forks source link

Skript relaod all > GUI issues #804

Closed Spiralexe closed 7 years ago

Spiralexe commented 7 years ago

After reloading all any custom menu when opened is screwed stealing is possible and commands don't run when clicking.

I tested both SKquery menu's and Tuske menu's and both behave this way after reload all.

no errors on console after the reload. I tested this on both v29 and v30 and it was the same results

http://i.imgur.com/z66M1ma.gifv heres a gif of the issue

melinstagibson commented 7 years ago

can confirm but idk... not a fan of "/reload all", it just kinda seems prone to errors by principle so i usually dont use it. just like /reload on the server

Spiralexe commented 7 years ago

reload all is useful when multiple scripts use a function

TheBentoBox commented 7 years ago

This isn't a vanilla Skript issue though is it? This sounds more like a problem with TuSKe or SkQuery's GUI effects not handling reloads correctly, which is a problem on their end. Correct me if I'm wrong but otherwise this doesn't belong here so I'll close it.

Spiralexe commented 7 years ago

this isn't an issue on v25 so something changed in skript to break it

TheBentoBox commented 7 years ago

Might have something to do with the changes to the parser to support async parsing.

Spiralexe commented 7 years ago

Considering it gives no errors how are addon dev's supposed to know what's breaking it? This seems more of a skript issue

bensku commented 7 years ago

Considering that, how would I fix this? To put it simply, I'll take this up with addon devs in question later. Cannot help you with this right now.

That being said, @Tuke-Nuke couldn't replicate with latest version of Skript (see the link above). I'm curious, but for now going to close this. Will be back after talking to addon devs if this is Skript issue.

Spiralexe commented 7 years ago

I don't think the issues are the same this is 1.12 and it give no errors as hid did