search

SkriptLang / skript-aliases

Aliases for Skript
19 stars 35 forks source link

Add hanging signs to the sign category #101

Open TheLimeGlass opened 9 months ago

TheLimeGlass commented 9 months ago

any oak sign should reflect any sign regardless of it's placement, as long as it's an oak sign, it will fall under the oak sign category.

Fusezion commented 7 months ago

We're shocked by this?

TheLimeGlass commented 7 months ago

Damn that's crazy https://github.com/SkriptLang/Skript/issues/6220

sovdeeth commented 7 months ago

The issue with this is that "oak sign" shouldn't include hanging oak signs, in my opinion. "Any oak sign" should, though, for comparison. It'd be pretty simple to split the two up.

Moderocky commented 7 months ago

Damn that's crazy SkriptLang/Skript#6220

Your PR does not address this issue at all. The issue you have linked is about warped and crimson (the pink and blue nether wood types) hanging signs not being included in the signs alias, and cherry and bamboo regular signs not being included in the alias. This PR doesn't add either of these missing things to the alias, it adds the hanging signs to the regular signs alias.