SkriptLang / skript-aliases

Aliases for Skript
20 stars 36 forks source link

Add iron golem spawn egg #109

Closed TheGallium closed 7 months ago

TheGallium commented 8 months ago

Referring to issue #108

Fusezion commented 8 months ago

I'm not sure how I feel about making iron optional. as snow golem also exists and if we're missing iron we're likely missing that one

*and let's not talk about spawn (entity) even being valid across spawn eggs, this is just innately wrong image

sovdeeth commented 8 months ago

I'm not sure how I feel about making iron optional. as snow golem also exists and if we're missing iron we're likely missing that one

*and let's not talk about spawn (entity) even being valid across spawn eggs, this is just innately wrong image

good catch with the iron thing as far as the second point, i agree, but for a different pr.

TheGallium commented 8 months ago

The minecraft:iron_golem_spawn_egg item was added in 1.19.3, using it in 1.19 will not work. Also, for the making iron optional, I think golem should be the default but for the snow golem, snow would be required.

sovdeeth commented 8 months ago

I would prefer both be required. It's better to be explicit about thing to avoid confusion and future conflicts.

aabssmc commented 8 months ago

what about ender dragon & wither spawn eggs

APickledWalrus commented 7 months ago

Thanks for this!