[Suggestion] Removal of Items w/ ArmorTrim aliases

[ShaneBeee]

I would like to suggest the removal of the aliases for items with armor trims. To start:

[Skript] Loaded 232659 aliases in 4296ms # default
[Skript] Loaded 197964 aliases in 2638ms # without armor trim

• nearly 35k aliases just for items with armor trims
  • thats 15% of all aliases
  • thats added pressure on the server
  • if Minecraft adds more, this is going to get even more out of hand
  • most people don't know and/or will ever know about these aliases and/or how to guess them
• Minecraft allows for registering custom armor trims, these hardcoded values just hurt that process
• These don't really flow with the rest of the aliases. It would be the equivalent of having aliases for every variation of an item with enchantments. Items with applied armor trims are not found in the game by default nor are they in the creative menu, its something the player applies with a smithing table.

[sovdeeth]

I'd be in favor of this.

[Moderocky]

Absolutely agree, we're planning to start deprecating aliases as of 2.9 anyway and moving towards and optional (opt-in) model in future.

[Fusezion]

Could be made into the same system used for potions +1

[Moderocky]

moving towards and optional (opt-in) model in future.

Our preliminary idea is to cut these out and provide an armor-trims.sk that people can drop in to restore the current usage. The same can probably be done for other (problematic) alias groups, before the complete removal.