search

SkriptLang / skript-aliases

Aliases for Skript
20 stars 36 forks source link

Update brewing, food, decoration, and misc #14

Closed APickledWalrus closed 6 years ago

APickledWalrus commented 6 years ago

Brewing

Fixed mistakes in potions (long night vision and fire resistance) Replaced "golden" with "gold[en]" in glistering melons

Decoration

Updated furnaces (makes more sense with what people would use IMO) huge -> [huge] in mushrooms

Foodstuffs

Grammatical fixes for baked potatoes and porkchops Updated fishes for "more proper plurals" (may be wrong)

Misc

Grammatical fixes for nether warts Added empty maps and filled maps Added fireworks (durations 0 - 3 (default))

TheBentoBox commented 6 years ago

Looks good overall, nice catches. I left some comments but didn't do it as a review because most of them are more of a matter of opinion or a question I have myself as opposed to something you specifically should fix before merge.

APickledWalrus commented 6 years ago

I looked through all the comments and everything should be good now.

TheBentoBox commented 6 years ago

Looks good to me now.

I'm honestly not sure how best to handle the furnace thing since it seems like it's situational; when giving a furnace, it should give an unlit furnace without having to say so. When comparing to a block, a lit furnace should still be considered a furnace. Hard to say what is more intuitive (default being both vs. default being unlit). Always open to feedback!

Either way, definitely good to merge now I think. Thanks again, great contributions and you've been a big help!