search

SkriptLang / skript-aliases

Aliases for Skript
20 stars 36 forks source link

Added redstone category aliases (first pass) #2

Closed TheBentoBox closed 6 years ago

TheBentoBox commented 6 years ago

This is a first pass at a full category from the creative inventory with the new aliases system. I've tried to separate out the items in this category into logical subcategories based on the new ability to create freely named scopes for storing the aliases.

There is a notable issue here that I've discussed with bensku: the new aliases system currently doesn't support 1.13's shift to block states. These are essentially a reimagining of data values as named key-value pairs that represent various states of the block (a bit of a "duh" given the name "block states"). For example, what may have been log:0 in 1.12 and below (a vertical oak log) would now be oak_log[axis=y] -- axis is a block state for blocks that can be placed along the three axes (such as logs and pillars), and y is one of the possible values (as are x and z, of course).

Because support for these is understandably not present yet, sub-states of blocks are not represented at all yet, e.g. the current aliases have support for different repeater delays (1-tick-delay repeater), while this file does not. I also haven't added any support for pre-1.13 block states yet via data values; I just wanted to get this PR up to get everyone's opinions on the general layout of how these files should be done (category naming, spacing, etc.), which is why I specifically requested reviews.

The last issue I can think of is that some of these aren't backward compatible with the old aliases, e.g. I realized while writing this that I forgot to make diode an alternate syntax for repeaters. I'll do another pass soon to try to make everything compatible with the current aliases.

TheBentoBox commented 6 years ago

Oops! I usually use tabs but changed the setting recently for something else and forgot to go back. Should be good now.