Closed ShaneBeee closed 6 years ago
ShaneBeee
commented
6 years ago 
TheBentoBox
commented
6 years ago I intentionally removed the block states from the {default} states on all variations at the request of bensku, he said Minecraft should be left to handle the default states of blocks as opposed to us declaring them, so your piston variation change should be reverted. I'll look into the snow layer one, though; I'm pretty sure there are larger issues there with the snow layer/block aliases.
ShaneBeee
commented
6 years ago The piston one ran an error.... maybe its because the hyphen was left there? I'll do some testing with that one!
As for the snow one... I will also do more testing. ~Its a tad hard as skript doesn't want to let me place blocks~
TheBentoBox
commented
6 years ago Maybe, please test as much as you feel like -- we're super alpha right now so more testing never hurts!
TheBentoBox
commented
6 years ago On closer inspection, I'm just gonna close this PR since there are a few snow layer issues. Someone added aliases for the layered snow block to the building.sk file even though we already have them in the decoration.sk file, which is why there are issues with the snow block aliases.
However, I would not have noticed these issues without you making this pull request, so thank you again! I'll fix this issue now.
ShaneBeee
commented
6 years ago OHHH gotcha, ok that makes sense now
TheBentoBox
commented
6 years ago I think I just fixed it with the latest push! I think bensku added these new aliases since he needed a way to reference the full thickness snow layer in the code (since we now use the aliases for certain things in the code of Skript itself) but he didn't realize they were already in the decorations file (easy mistake).
bensku
commented
6 years ago Oops, sorry! Originally wrote that in Java and decided to make it configurable at last moment.