search

SkriptLang / skript-aliases

Aliases for Skript
20 stars 36 forks source link

Added combat category aliases (first pass) #5

Closed TheBentoBox closed 6 years ago

TheBentoBox commented 6 years ago

This one should actually be pretty comprehensive -- this category doesn't have any blocks which need to utilize block states, and I already broke out everything properly by their update with a conditional. I decided to just name each section after the update's official name.

If we were able to mark variation sections as being global, it would likely be better in the future to have a more global potions variation since the tipped arrows here use almost all of the same variations as potions would. Speaking of, I should be able to do a PR for brewing somewhat soon as well!

bensku commented 6 years ago

Variations are defined globally, but they must be loaded before they're used. Two-pass aliases parsing is not something I'd like to do: doing it for functions was quite time consuming to get working reliably.

TheBentoBox commented 6 years ago

That works perfectly fine, that way I can just name the variations file appropriately to have it load first for more any global variations like that (especially important for block state variations).