search

SkriptLang / skript-aliases

Aliases for Skript
20 stars 36 forks source link

Legacy items fix #51

Closed ShaneBeee closed 4 years ago

ShaneBeee commented 4 years ago

Description

There is a big issue in Skript with Minecraft versions 1.12.2 and below, where certain aliases are not working, ie:

You are not able to set these items, and if you try to return the item (ie: target block of player) it returns a Bukkit enum (ex: if the target block is a wheat plant it returns CROPS)

This PR will go along with a fix in Skript, see PR here, and should only be accepted/merged once that PR is merged.

Special Note:

I wanted to jump the gun before someone asks about this change:

old fluids:
    minecraft version = 1.12.2 or older
    flowing water = minecraft:flowing_water
    flowing lava = minecraft:flowing_lava

"But you can't place flowing water", well, you actually can, the water on the left is water and the water on the right is flowing water

Screen Shot 2019-10-24 at 3 54 27 PM
TheBentoBox commented 4 years ago

Looks really good, thanks for these fixes!