search

SkriptLang / skript-aliases

Aliases for Skript
20 stars 36 forks source link

Fix Redstone Lamp Litness #52

Closed Wealthyturtle closed 4 years ago

Wealthyturtle commented 4 years ago

See https://github.com/SkriptLang/Skript/issues/2591 for more details.

TheBentoBox commented 4 years ago

This isn't right:

  1. You're editing a 1.12.2 or older aliases block but appear to be trying to use block states. Block states are not supported before 1.13.
  2. That's not the syntax for denoting block states. They go within square brackets and with no space between them and the ID.
  3. I mostly referenced this page for determining how old IDs were converted into new IDs for 1.13+. Perhaps it's inaccurate but as far as I can tell from that list lit_redstone_lamp DID exist prior to the flattening.

Past that, I believe it was in fact necessary back then to have an entirely different ID for the lit state because I don't think a block's light level could differ solely based on block state (or rather data value back then).

Wealthyturtle commented 4 years ago

Oops, sorry didn't see that I made changes for < 1.13, and that minecraft:lit_redstone_lamp existed before 1.13. The weird thing is, even though I modified the version prior to 1.13, it fixed the issue on my 1.14.4 test server? (I confirmed that the bug existed prior to my edits)