search

SkriptLang / skript-aliases

Aliases for Skript
20 stars 36 forks source link

NetherUpdate Prep #59

Closed ShaneBeee closed 4 years ago

ShaneBeee commented 4 years ago

As most know the first snapshot of The Nether Update came out. With that brought a whole bunch of new things. It's also been said that "tons more stuff is coming". With that said, I figured I would get a head start on the new items/blocks before they start adding a lot more.

As more snapshots come out and new items/blocks are added I will keep updating this PR.

ShaneBeee commented 4 years ago

Really appreciate this work, it's a huge help. I'm sure this is all still in progress but I'm just going to leave comments on the things I've noticed on first pass for the sake of tracking.

Ok, I think I caught all of those. I used the wood type, as suggested, and refactored a few other things to make it a little more future safe.

legofreak1999 commented 4 years ago

I believe blockstates for 1.16 walls are missing.

[north/east/south/west=none/low/tall]

And these seems to be missing at all rn 1.13 >.

Walls: [north/east/south/west/up=true/false]

Fence: [north/east/south/west=true/false]

Chorus Plant: [north/east/south/west/up/down=true/false]

Sorry for mentioning the 1.13+ stuff here but ig its better to know so u can think about any global variations.

ShaneBeee commented 4 years ago

I believe blockstates for 1.16 walls are missing.

[north/east/south/west=none/low/tall]

And these seems to be missing at all rn 1.13 >.

Walls: [north/east/south/west/up=true/false]

Fence: [north/east/south/west=true/false]

Chorus Plant: [north/east/south/west/up/down=true/false]

Sorry for mentioning the 1.13+ stuff here but ig its better to know so u can think about any global variations.

This has been discussed in our dev chat, and due to the amount of variations PER block, this would end up being an insanely complicated alias, and in turn would not work out well. We feel that something like this should probably be done as an expression of sorts

ShaneBeee commented 4 years ago

Okay, I did my testing on 1.16.1 (spigot) and got 120+ errors. Those were fixed, and everything seems fine. I tested on 1.15.2 as well to make sure I didn't break any old aliases.

Seems good to go :)

APickledWalrus commented 4 years ago

Looks good to me! 👍

TheBentoBox commented 4 years ago

Looks great, good stuff!