search

SkriptLang / skript-aliases

Aliases for Skript
20 stars 36 forks source link

Add transportation category aliases #9

Closed Blueyescat closed 6 years ago

Blueyescat commented 6 years ago

Not ready to merge, waiting https://github.com/SkriptLang/skript-aliases/issues/8.

TheBentoBox commented 6 years ago

Just a few things:

  1. Boats and elytas were added in 1.9 and I've been trying to support 1.8; aliases shouldn't be the thing that decides version compatibility. Those should be separated into a section for 1.9 and on. Additionally, the oak boat's ID was changed from boat to oak_boat in 1.13 so that needs to be addressed.
  2. We need data-value based aliases for the rails as well. You could declare the {rail straight/curved/powered} variations in two separate sections, one using block states for 1.13 and newer and one using data values for 1.12 and older, and then just define the rail aliases once just like you are now in a third section. It should work since it will create the appropriate variation based on the server version.
  3. I'm not sure if you're supposed to put a space between the - and the block state. At the very least that's not how the block states are defined via in-game commands nor how they're used by Spigot, but I'm not sure how specifically the alias parser expects them.

Looks real good overall though. I'll push a commit to clear out my transportation aliases so we don't have to deal with merge conflicts.

TheBentoBox commented 6 years ago

Cheers 💕