SkriptLang / skript-reflect

Powerful reflection utilities for Skript.
MIT License
56 stars 19 forks source link

Custom event with priority doesn't work #65

Closed eiqq closed 10 months ago

eiqq commented 1 year ago

Describe the bug

Custom event with priority does not work. without priority, it works. ex) on castskill with priority monitor: broadcast "!" <--- errors

on castskill: broadcast "!" <--- work

on the skript 2.6.4 with skript-reflect 2.3, both codes above was working

Screenshots 2023-03-28_00 17 27

Server information

Additional context

TPGamesNL commented 1 year ago

Skript adds the syntax for event priorities during registration (Skript.registerEvent), but skript-reflect's custom events are registered differently (an event without patterns is registered when the addon is loaded, and patterns are added when a custom event is being parsed).

Can probably be fixed by manually adding the priority suffix to patterns from custom events

TPGamesNL commented 10 months ago

Fixed in https://github.com/TPGamesNL/skript-reflect/commit/0abbe26b580017d23a04398cd2a33c5b69908897