Hi @roneigebert
As we discussed in private, it would be better if you send a PR against the version-2.1.x.
I have no concerns about the code itself once it was quite straightforward, clear and had a proper unit test for this case. Thus if you send me the same PR to the version-2.1.x I'll approve it. ;)
Hi @roneigebert As we discussed in private, it would be better if you send a PR against the version-2.1.x.
I have no concerns about the code itself once it was quite straightforward, clear and had a proper unit test for this case. Thus if you send me the same PR to the version-2.1.x I'll approve it. ;)
Cheers!