search

Skullabs / kikaha

A fast middleware designed for microservices
https://skullabs.github.io/kikaha/
Apache License 2.0
59 stars 13 forks source link

AWS Sdk update #266

Closed roneigebert closed 4 years ago

roneigebert commented 5 years ago

Current version is 1.11.125 (Apr, 2017). Last version is 1.11.656 (Oct, 2019)

In the new version are important features (for example, datapoints to alarm (cloudwatch)).

jardelnovaes commented 4 years ago

Hi @miere!

I'm not able to check the codeship error, could you check it? I ran all tests on my local machine yesterday without any problem.

miere commented 4 years ago

That's fine, mate. Just let me know when the issue is resolved. Once done I'll first run it locally (double-checking) and then from Codeship (on an attempt to debug what's happening).

There might be some delay in our communication, as we're 14 hours apart, you should have a new release version quite soon.

On Thu, Feb 20, 2020 at 2:18 AM Jardel Novaes notifications@github.com wrote:

Hi @miere https://github.com/miere!

I'm not able to check the codeship error, could you check it? I ran all tests on my local machine yesterday without any problem.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Skullabs/kikaha/issues/266?email_source=notifications&email_token=AAD7NUBJPBA5TXYCT5IIXITRDVEUJA5CNFSM4JDB57PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMIGLPY#issuecomment-588277183, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD7NUFGV4HLMFIRRY2JX6LRDVEUJANCNFSM4JDB57PA .

-- / Miere L. Teixeira /

jardelnovaes commented 4 years ago

This issue (#266) was done yesterday, but the codeship build failed and I wasn't able to check the reason.

After solving the codeship problem who should close the issue?

miere commented 4 years ago

Once I approve the PR, I can merge for you if you want.

On Thu, Feb 20, 2020 at 11:22 AM Jardel Novaes notifications@github.com wrote:

This issue (#266 https://github.com/Skullabs/kikaha/issues/266) was done yesterday, but the codeship build failed and I wasn't able to check the reason.

After solving the codeship problem who should close the issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Skullabs/kikaha/issues/266?email_source=notifications&email_token=AAD7NUHS4WFZCLTJMABLAHLRDXEKTA5CNFSM4JDB57PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMKHUBQ#issuecomment-588544518, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD7NUEPUCRUDXM6HYXZ22LRDXEKTANCNFSM4JDB57PA .

-- / Miere L. Teixeira /

jardelnovaes commented 4 years ago

The PR #270 that "fixes" the issue #266 was already merged by you, but this issue (#266) is still opened.

My doubt is if I should close this issue or if you'd like to close it.

I think that we should check the codeship before closing this issue.

miere commented 4 years ago

The ideal workflow is, as happens in most (if not all) the communities I've been following:

Note that Maven Central upload is not included in our CI/CD tool pipeline yet. I'm intending to overhaul it in the 3.0 release, as I'm willing to keep versions rolling when new releases of Undertow and other dependencies are made available.

On Thu, Feb 20, 2020 at 12:21 PM Jardel Novaes notifications@github.com wrote:

The PR #270 https://github.com/Skullabs/kikaha/pull/270 that "fixes" the issue #266 https://github.com/Skullabs/kikaha/issues/266 was already merged by you, but this issue (#266 https://github.com/Skullabs/kikaha/issues/266) is still opened.

My doubt is if I should close this issue or if you'd like to close it.

I think that we should check the codeship before closing this issue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Skullabs/kikaha/issues/266?email_source=notifications&email_token=AAD7NUFFWTSFGXNADEISVATRDXLIZA5CNFSM4JDB57PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMKLV5Y#issuecomment-588561143, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD7NUE27C2RA4C3DTDYRL3RDXLIZANCNFSM4JDB57PA .

-- / Miere L. Teixeira /

miere commented 4 years ago

The PR #270 https://github.com/Skullabs/kikaha/pull/270 that "fixes" the issue #266 https://github.com/Skullabs/kikaha/issues/266 was already merged by you, but this issue (#266 https://github.com/Skullabs/kikaha/issues/266) is still opened.

I forgot to mention that you should also use commit messages that tells GitHub to close your issue automatically when your PR is approved and merge. Like: Fixes #266 in case of bugs or Closes #266 in case of features and enhancements.

jardelnovaes commented 4 years ago

Nice explanation @miere, maybe it could be part of the contribuiting.md file.

About this:

is up to the CI/CD to perform checks every commit (which is broken but I can check by myself as well).

I don't have access to check the CI/CD result. Could you check why the build is broken?

kikaha-issue-266-001

kikaha-issue-266-002

About the "Fixes" and "Closes" I didn't use it because I wasn't sure if you'll appreciate the automation or if you'd like to control this by yourself, I'll follow your instructions in the next PR/commits.

We'd like to include the PR (#271 - About Permission Denied Handler) in this "release version". Could you review the #271 as well?

miere commented 4 years ago

Don't worry about the CI/CD tool issue. Apparently it's been broken for around 4 months already. I shall fix it properly by tomorrow (Saturday). Yesterday I got meetings at night and wasn't capable to review your second PR as well. It turns out that your just included feature might be quite useful for me as well.

I shall review Codeship permission too. I was supposed to be publicly available as it is an open source software.

Thanks for that.

On Fri, Feb 21, 2020 at 1:20 AM Jardel Novaes notifications@github.com wrote:

Nice explanation @miere https://github.com/miere, maybe it could be part of the contribuiting.md file.

About this:

is up to the CI/CD to perform checks every commit (which is broken but I can check by myself as well).

I don't have access to check the CI/CD result. Could you check why the build is broken?

[image: kikaha-issue-266-001] https://user-images.githubusercontent.com/20839085/74941932-a8e46780-53d2-11ea-9531-e3682d981dd9.PNG

[image: kikaha-issue-266-002] https://user-images.githubusercontent.com/20839085/74941953-b0a40c00-53d2-11ea-8989-ed63b530afc2.PNG

About the "Fixes" and "Closes" I didn't use it because I wasn't sure if you'll appreciate the automation or if you'd like to control this by yourself, I'll follow your instructions in the next PR/commits.

We'd like to include the PR (#271 https://github.com/Skullabs/kikaha/pull/271 - About Permission Denied Handler) in this "release version". Could you review the #271 https://github.com/Skullabs/kikaha/pull/271 as well?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Skullabs/kikaha/issues/266?email_source=notifications&email_token=AAD7NUB644SZCW64C2IE6L3RD2GUBA5CNFSM4JDB57PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMOJCFI#issuecomment-589074709, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD7NUDICXNKWTGTVQW3SHDRD2GUBANCNFSM4JDB57PA .

-- / Miere L. Teixeira /