search

Skullabs / kikaha

A fast middleware designed for microservices
https://skullabs.github.io/kikaha/
Apache License 2.0
59 stars 13 forks source link

Fix the special regex chars when they're part of file path (Windows) #276

Closed jardelnovaes closed 4 years ago

jardelnovaes commented 4 years ago

Fixing the special regex chars when they're part of file path (Windows) (e.g. c:\kikaha-test\test-app)

Some of these chars are \Q, \E, \k.

The problem occurs with deploy to Aws.

jardelnovaes commented 4 years ago

When the problem occurs it throws an Exception. If we remove the code that fixes the problem the exception will be thrown.

I can use a try catch to provide a feedback.

jardelnovaes commented 4 years ago

I'll include an assertion, I've focused on the exception and not on the method result, my fault!

jardelnovaes commented 4 years ago

Now the test will check if the method fixEntryName is really doing its work. If the regex problem occurs the test will failed by throwing an exception (it already had this behavior before the last commit)

miere commented 4 years ago

@jardelnovaes

I've found a small drawback related to Mac and Linux build due to the changes you've made. But no worries, mate, I've fixed it already. Hopefully, it will won't have any impact on your Windows machine.

Thanks for the PR

miere commented 4 years ago

Version 2.1.10.Final is on Sonatype Staging Repository already. Before I roll it out, do you mind to make a last test in your Windows machine? As soon as I've received your feedback I shall publish into Maven Central.

jardelnovaes commented 4 years ago

Hi @miere

You wrote: I've found a small drawback related [...] I've fixed it already.

But I wasn't able to find this fix, Did you put it into version-2.1.x our just into 2.1.10.Final compiled version?

About the tests I've finished them using the SonaType Stagging Repository (2.1.10.Final) and I found no problems.

miere commented 4 years ago

It is in the version-2.1.x branch already. I've rushed into fix it because I didn't want you guys to keep waiting 14hours (as I'm in the other side of the world) to get your patch released. Hope you don't mind.

I just published. It shall be automatically rolled out by Sonatype to Mavel Central in the next couple of hours.

On Thu, Mar 26, 2020 at 1:36 AM Jardel Novaes notifications@github.com wrote:

Hi @miere https://github.com/miere

You wrote:

I've found a small drawback related [...] I've fixed it already.

But I wasn't able to find this fix, Did you put it into version-2.1.x our just into 2.1.10.Final compiled version?

About the tests I've finished them using the SonaType Stagging Repository (2.1.10.Final) and I found no problems.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Skullabs/kikaha/pull/276#issuecomment-603874893, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD7NUCCFWUTAZDN4JMGW73RJIJFXANCNFSM4LTC4P5A .

-- / Miere L. Teixeira /

jardelnovaes commented 4 years ago

No problems.