Skullabs / kikaha

A fast middleware designed for microservices
https://skullabs.github.io/kikaha/
Apache License 2.0
59 stars 13 forks source link

AWS CodeDeploy custom folder don't preserve sub-directories #278

Closed roneigebert closed 3 years ago

roneigebert commented 4 years ago

My config

image

Files

image

Deployment package

image

The problem The "bin" folder is removed, I need to preserve subfolders. Important: if I use the default kikaha provided codedeploy package, subfolders are preserved.

miere commented 4 years ago

Thanks for reporting, mate. I'll take a closer look at it later this week.

On Fri, Aug 14, 2020 at 2:38 AM Ronei notifications@github.com wrote:

My config

[image: image] https://user-images.githubusercontent.com/7042068/90161114-085f7680-dd69-11ea-9100-d77322d69ada.png

Files

[image: image] https://user-images.githubusercontent.com/7042068/90161187-2a58f900-dd69-11ea-92df-47316269bd23.png

Deployment package

[image: image] https://user-images.githubusercontent.com/7042068/90161347-5eccb500-dd69-11ea-8718-e7d4f46613ef.png

The problem The "bin" folder is removed, I need to preserve subfolders. Important: if I use the default kikaha provided codedeploy package, subfolders are preserved.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Skullabs/kikaha/issues/278, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD7NUBHCPZKSXJO3TDFONDSAQJHRANCNFSM4P6UDS2Q .

miere commented 4 years ago

Mate,

I've been really busy last week and should probably be in the next couple of weeks as I'll be working on two shifts (Belgium + Australia) for a brief period of time. Knowing your good work for such a long time, if you submit a PR I'll make sure to approve it. We can also automate the release to the Maven central just like I did on Injector https://github.com/Skullabs/injector/blob/master/.github/workflows/release.yml. What do you think?

On Mon, Aug 17, 2020 at 9:48 AM Miere Teixeira miere.teixeira@gmail.com wrote:

Thanks for reporting, mate. I'll take a closer look at it later this week.

On Fri, Aug 14, 2020 at 2:38 AM Ronei notifications@github.com wrote:

My config

[image: image] https://user-images.githubusercontent.com/7042068/90161114-085f7680-dd69-11ea-9100-d77322d69ada.png

Files

[image: image] https://user-images.githubusercontent.com/7042068/90161187-2a58f900-dd69-11ea-92df-47316269bd23.png

Deployment package

[image: image] https://user-images.githubusercontent.com/7042068/90161347-5eccb500-dd69-11ea-8718-e7d4f46613ef.png

The problem The "bin" folder is removed, I need to preserve subfolders. Important: if I use the default kikaha provided codedeploy package, subfolders are preserved.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Skullabs/kikaha/issues/278, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD7NUBHCPZKSXJO3TDFONDSAQJHRANCNFSM4P6UDS2Q .

roneigebert commented 4 years ago

No problem Miere, it's important buts it's not urgent. I'll send a PR soon.

miere commented 3 years ago

@roneigebert any thoughts?

roneigebert commented 3 years ago

@miere please take a look https://gist.github.com/roneigebert/ea8a538d271c2be465dfb3d15e230e55 I still haven't run tests (I think we need test it on windows and linux) but I hope it will solve the problem

miere commented 3 years ago

Cool. Will be waiting for the PR then.

On Tue, Feb 9, 2021 at 9:41 AM Ronei notifications@github.com wrote:

@miere https://github.com/miere please take a look https://gist.github.com/roneigebert/ea8a538d271c2be465dfb3d15e230e55 I still haven't run tests (I think we need test it on windows and linux) but I hope it will solve the problem

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Skullabs/kikaha/issues/278#issuecomment-775512252, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD7NUF7Q5R2ZO6FXB7TFYTS6BSCDANCNFSM4P6UDS2Q .

-- / Miere L. Teixeira /

roneigebert commented 3 years ago

@miere done! https://github.com/Skullabs/kikaha/pull/277