search

Skullabs / kikaha

A fast middleware designed for microservices
https://skullabs.github.io/kikaha/
Apache License 2.0
59 stars 13 forks source link

AWS CodeDeploy - config to ignore stop step errors #279

Closed roneigebert closed 3 years ago

roneigebert commented 4 years ago

For blue/green deployments it's usefull to use the "withIgnoreApplicationStopFailures" method to ignore any errors in old instances (before/after/blocktraffic) - sometimes erros occur when scaling activity and deploy are running at the same time.

https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/codedeploy/model/CreateDeploymentRequest.html#withIgnoreApplicationStopFailures-java.lang.Boolean-

miere commented 3 years ago

I think this is a good improvement. How shall we proceed? Can we pair together on this and get this issue solved? I'm keen to wrap a new release of Kikaha for this week.

roneigebert commented 3 years ago

@miere what about a boolean flag "ignoreApplicationStopFailures" on KikahaS3DeployerMojo with default "false"?

miere commented 3 years ago

I think that's a sensible solution. The default behaviour, in this case, makes sense to be more strict (set to false). People can relax this behaviour by setting it to true.

roneigebert commented 3 years ago

@miere done! https://github.com/Skullabs/kikaha/pull/277