search

Skullabs / kikaha

A fast middleware designed for microservices
https://skullabs.github.io/kikaha/
Apache License 2.0
59 stars 13 forks source link

fix: maven plugin compatible with most recent version maven #281

Closed heeisenbeergg closed 3 years ago

heeisenbeergg commented 3 years ago

Quoted by Miere https://github.com/Skullabs/kikaha/issues/272#issue-569209791

Due to old API being used, build breaks due to lack of compatibility of a few features. Once build though it is still runnable on 3.x version of Maven.

Expected behaviour

Should be possible to build the Maven plugin using:

  • modern version of the JDK
  • modern Maven 3.6 or superior

This PR has the expected behaviors:

Note: I ran the tests using kikaha in version 2.1.10.Final because in version 2.1.10-SNAPSHOT does not compile.

miere commented 3 years ago

Thanks for that, mate. I shall check it out later this weekend too.

On Sat, Jan 30, 2021 at 12:40 PM Lucas William Cristovão < notifications@github.com> wrote:

Quoted by Miere #272 (comment) https://github.com/Skullabs/kikaha/issues/272#issue-569209791

Due to old API being used, build breaks due to lack of compatibility of a few features. Once build though it is still runnable on 3.x version of Maven. Expected behaviour

Should be possible to build the Maven plugin using:

  • modern version of the JDK
  • modern Maven 3.6 or superior

This PR has the expected behaviors:

  • modern version of the JDK
  • modern Maven 3.6 or superior

Note: I ran the tests using kikaha in version 2.1.10.Final because in version 2.1.10-SNAPSHOT does not compile.

You can view, comment on, or merge this pull request online at:

https://github.com/Skullabs/kikaha/pull/281 Commit Summary

  • feat: add lombok version 1.18.18 to maven-compiler-plugin
  • fix: add javax.annotation as dependency on kikaha-injection

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Skullabs/kikaha/pull/281, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD7NUAASOA72626NLS3SQTS4NPRFANCNFSM4WZZ3LRQ .