Skulltrail192 / One-Core-Api-Source

A complete layer to get compatibility on XP/2003 for newer applications
http://shorthornproject.com
GNU General Public License v2.0
515 stars 40 forks source link

GetIfEntry bug? #43

Closed Eugenij-W closed 11 months ago

Eugenij-W commented 2 years ago

bug?

https://github.com/Skulltrail192/One-Core-Api/blob/5a61e5632a88193406438e29ef2936669613890d/wrappers/base/iphlpapi_wrapper/iphlpapi.c#L1179

must be: if (GetIfEntry(&row) != NO_ERROR)

Eugenij-W commented 2 years ago

If the function succeeds, the return value is NO_ERROR.

the version in the repository returns an error if successful...

    if (GetIfEntry(&row)==0) 
        return ERROR_FILE_NOT_FOUND;

...and in case of a failure, it continues to work.

define NO_ERROR 0L

Skulltrail192 commented 11 months ago

I was fixed at version 3.0x.