H
Why is GetPosition protected? If there is a good reason, document it
When would we want to change the PID values of the motors? Also why return the ID when they passed it in? document it
Consider removing auto-generated comments
CPP
There are 2 setPosition functions, one as part of MotorManager and one as a local function. Are they both needed? Also both are blank.
Consider removing auto-generated comments
LucVader
commented
8 years ago
H Why is GetPosition protected? If there is a good reason, document it When would we want to change the PID values of the motors? Also why return the ID when they passed it in? document it Consider removing auto-generated comments
CPP There are 2 setPosition functions, one as part of MotorManager and one as a local function. Are they both needed? Also both are blank. Consider removing auto-generated comments