Closed ejancic closed 11 years ago
Skwerl
commented
11 years ago OK, what's missing is the lab set name. I'm pulling that from the summary field of the lab order section, which must be missing from the JSON you're exporting from. Can you populate the summary field and try again?
ejancic
commented
11 years ago It is non-trivial to associate a lab order right.. will probably take me 30 mins or so to try to fake it. It's also weird that we would need to have a lab name from the lab order because nothing else has used lab orders with lab results up to this point. Can you use the name field from the lab results if there's no summary field in the lab order?
Skwerl
commented
11 years ago Well there's a fundamental issue there. The structure of labs is like this:
There's a set of labs, with an order (optional) and results. Within the results are individual tests. This is how the JSON is structured basically.
Now I have a whole slew of concerns for after certification. For example, I believe each test should/could have its own LOINC code, in addition to the battery of tests (set of labs) having one as well. But that's not an issue that's being brought up so I'm just going to save it all for later.
However, one of them has been twisting my brain for awhile now. I have a LOINC code in the labResult object, but no corresponding descriptor. This has been pretty troublesome, because whenever I have to export a LOINC code, I almost always have to include a corresponding descriptor that is never right next to it.
But it was possible to work around that case. When I'm looping through each individual test in the labTestResult objects, I'm just pulling the LOINC code from the parent labResult object. It's a little messy/redundant, but we're getting by. Each test has exactly one LOINC code in the parent object they all share. It's a many-to-one relationship.
However, in this case here, it's not as simple. The only english descriptor for any result is in the object for the individual test, buried two levels deep. And there can be more than one of them, with different names. So when I have to give a set of labs a name, I have my one single LOINC code, but no single description. The only thing I could go on was the order summary.
TL;DR: In the JSON, I need one field for each lab (as in the set of labs, as opposed to each individual lab test) that can provide me with a description. It doesn't need to be the order summary necessarily, but there has to be exactly one for each item in the JSON's lab array.
Skwerl
commented
11 years ago Another way I could have put it would have been to ask how possible it'd be to add a description/summary on the same level in the hierarchy as the loincCode... with that, I wouldn't need to look at the order object.
ejancic
commented
11 years ago What did we use for this previously? I know this was passing yesterday — Sent from Mailbox for iPhone
On Thu, Apr 4, 2013 at 7:49 PM, Skwerl notifications@github.com wrote:
Another way I could have put it would have been to ask how possible it'd be to add a description/summary on the same level in the hierarchy as the loincCode... with that, I wouldn't need to look at the order object.
Reply to this email directly or view it on GitHub: https://github.com/reyinteractive/hs-util/issues/51#issuecomment-15936546
Skwerl
commented
11 years ago odd, i've always been using order summary.
ejancic
commented
11 years ago Adding a field to the API will also require a new app build. Any issue with reusing the name field from the lab results?
On Thursday, April 4, 2013, Skwerl wrote:
odd, i've always been using order summary.
— Reply to this email directly or view it on GitHubhttps://github.com/reyinteractive/hs-util/issues/51#issuecomment-15936923 .
Skwerl
commented
11 years ago More than one result = more than one name. Which do I use?
ejancic
commented
11 years ago Touché.. Can you take the first one? The field doesn't show up on the human readable so I'm not super concerned as long as it validates — Sent from Mailbox for iPhone
On Thu, Apr 4, 2013 at 8:27 PM, Skwerl notifications@github.com wrote:
More than one result = more than one name. Which do I use?
Reply to this email directly or view it on GitHub: https://github.com/reyinteractive/hs-util/issues/51#issuecomment-15937356
Skwerl
commented
11 years ago gnarly hack, but can do. if that's the best option. at least i can make it the last resort if there's no order summary.
ejancic
commented
11 years ago Agreed.. Does it pass validation? — Sent from Mailbox for iPhone
On Thu, Apr 4, 2013 at 8:42 PM, Skwerl notifications@github.com wrote:
gnarly hack, but can do. if that's the best option. at least i can make it the last resort if there's no order summary.
Reply to this email directly or view it on GitHub: https://github.com/reyinteractive/hs-util/issues/51#issuecomment-15937650
Skwerl
commented
11 years ago Yeah, CCD export passes with my JSON, now even when I remove lab order summary. Give it a shot.
The CCD export below is still failing validation. There are three labs associated to the patient and all three labs have type set.