search

SkyAPM / SkyAPM-nodejs

The NodeJS server side agent for Apache SkyWalking
Apache License 2.0
128 stars 86 forks source link

node v4.8.4 can't use this agent? #61

Closed guoyunlong666 closed 5 years ago

guoyunlong666 commented 5 years ago

my app can't startup,this is error: SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode at exports.runInThisContext (vm.js:53:16) at Module._compile (module.js:373:25) at Object.Module._extensions..js (module.js:416:10) at Module.load (module.js:343:32) at Function.Module._load (module.js:300:12) at Module.require (module.js:353:17) at require (internal/module.js:12:17) at Object. (/data/www/nodejs/node_modules/skyapm-nodejs/lib/instrumentation/index.js:22:16) at Module._compile (module.js:409:26) at Object.Module._extensions..js (module.js:416:10)

ascrutae commented 5 years ago

It seem like the agent miss ‘strict’, I will try to fix it.

On Fri, Mar 8, 2019 at 10:04 guoyunlong666 notifications@github.com wrote:

my app can't startup,this is error: SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode at exports.runInThisContext (vm.js:53:16) at Module._compile (module.js:373:25) at Object.Module._extensions..js (module.js:416:10) at Module.load (module.js:343:32) at Function.Module._load (module.js:300:12) at Module.require (module.js:353:17) at require (internal/module.js:12:17) at Object. (/data/www/nodejs/node_modules/skyapm-nodejs/lib/instrumentation/index.js:22:16) at Module._compile (module.js:409:26) at Object.Module._extensions..js (module.js:416:10)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SkyAPM/SkyAPM-nodejs/issues/61, or mute the thread https://github.com/notifications/unsubscribe-auth/AL3D34xx_z2jtvA4cJb1U8LkUq7uO7-zks5vUcP4gaJpZM4bkfLZ .

guoyunlong666 commented 5 years ago

That's great. Thank you.

ascrutae commented 5 years ago

@guoyunlong666 This issue had fixed, and I'm afraid not that current version cannot running in node.js 4.8.4, because of the GRPC that node.js agent use it to send data to the collector cannot running in node.js 4.8.4.

ascrutae commented 5 years ago

Ref: #62

ascrutae commented 5 years ago

Close this issue.