search

SkyAPM / SkyAPM-php-sdk

Replaced by https://github.com/apache/skywalking-php
https://skywalking.apache.org/
Apache License 2.0
421 stars 104 forks source link

[5.0.1] build with PHP <= 7.2 is broken #495

Closed remicollet closed 2 years ago

remicollet commented 2 years ago

Despite package.xml states PHP >= 7.0

libtool: compile:  gcc -std=c99 -I. -I/builddir/build/BUILD/php72-php-pecl-skywalking-5.0.1/NTS -DPHP_ATOM_INC -I/builddir/build/BUILD/php72-php-pecl-skywalking-5.0.1/NTS/include -I/builddir/build/BUILD/php72-php-pecl-s
kywalking-5.0.1/NTS/main -I/builddir/build/BUILD/php72-php-pecl-skywalking-5.0.1/NTS -I/opt/remi/php72/root/usr/include/php -I/opt/remi/php72/root/usr/include/php/main -I/opt/remi/php72/root/usr/include/php/TSRM -I/opt/
remi/php72/root/usr/include/php/Zend -I/opt/remi/php72/root/usr/include/php/ext -I/opt/remi/php72/root/usr/include/php/ext/date/lib -I/builddir/build/BUILD/php72-php-pecl-skywalking-5.0.1/NTS/src -DHAVE_CONFIG_H -O2 -fl
to=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-stro
ng -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -c /builddir/build/BUILD/php72-php-pecl-skywalking-5.0.1/NTS/src/sky_core_tag.c 
 -fPIC -DPIC -o src/.libs/sky_core_tag.o
In file included from /opt/remi/php72/root/usr/include/php/Zend/zend.h:42,
                 from /opt/remi/php72/root/usr/include/php/main/php.h:35,
                 from /builddir/build/BUILD/php72-php-pecl-skywalking-5.0.1/NTS/src/sky_util_php.h:21,
                 from /builddir/build/BUILD/php72-php-pecl-skywalking-5.0.1/NTS/src/sky_core_tag.c:22:
/opt/remi/php72/root/usr/include/php/Zend/zend_signal.h:48:9: error: unknown type name 'siginfo_t'
   48 |         siginfo_t *siginfo;
      |         ^~~~~~~~~
In file included from /opt/remi/php72/root/usr/include/php/Zend/zend.h:42,
                 from /opt/remi/php72/root/usr/include/php/main/php.h:35,
                 from /builddir/build/BUILD/php72-php-pecl-skywalking-5.0.1/NTS/src/sky_util_php.h:21,
                 from /builddir/build/BUILD/php72-php-pecl-skywalking-5.0.1/NTS/src/sky_core_tag.c:22:
/opt/remi/php72/root/usr/include/php/Zend/zend_signal.h:97:53: warning: 'struct sigaction' declared inside parameter list will not be visible outside of this definition or declaration
   97 | ZEND_API int zend_sigaction(int signo, const struct sigaction *act, struct sigaction *oldact);
      |                                                     ^~~~~~~~~
remicollet commented 2 years ago

Sorry for the noise... compiler issue

(btw, you use std99 sources, and this break some build with old compiler)