Closed Fengrui-Liu closed 2 years ago
Thanks for the PR! let me take a look.
Looks good enough for now; please add and lock corresponding dependencies to Poetry. Then it's good to merge.
Missing Pandas and Scipy (and Numpy) from the pyproject.toml
, please add them through poetry add xxx
@Superskyyy In every code base, it is always better to have CI to check the things you mentioned. e2e is always being added once the basic APIs are there.
Looks good enough for now; please add and lock corresponding dependencies to Poetry. Then it's good to merge. Missing Pandas and Scipy (and Numpy) from the
pyproject.toml
, please add them throughpoetry add xxx
OK, finished.
Recently, I am trying to figure out how Ray works, I will use it in our project later.
Good. thanks.
@Superskyyy In every code base, it is always better to have CI to check the things you mentioned. e2e is always being added once the basic APIs are there.
Yes I'll add those soon, linters are ready at my local.
Note: A basic anomaly detector, which can help to clarify the pipeline of this project, like the input and the output.