SkyAPM / aiops-engine-for-skywalking

This is an incubating repository of the Apache SkyWalking AIOps Engine
https://github.com/apache/skywalking/discussions/8883
Apache License 2.0
37 stars 7 forks source link

The first metric anomaly detector . #15

Closed Fengrui-Liu closed 2 years ago

Fengrui-Liu commented 2 years ago

Note: A basic anomaly detector, which can help to clarify the pipeline of this project, like the input and the output.

Superskyyy commented 2 years ago

Thanks for the PR! let me take a look.

Superskyyy commented 2 years ago

Looks good enough for now; please add and lock corresponding dependencies to Poetry. Then it's good to merge. Missing Pandas and Scipy (and Numpy) from the pyproject.toml , please add them through poetry add xxx

wu-sheng commented 2 years ago

@Superskyyy In every code base, it is always better to have CI to check the things you mentioned. e2e is always being added once the basic APIs are there.

Fengrui-Liu commented 2 years ago

Looks good enough for now; please add and lock corresponding dependencies to Poetry. Then it's good to merge. Missing Pandas and Scipy (and Numpy) from the pyproject.toml , please add them through poetry add xxx

OK, finished.

Recently, I am trying to figure out how Ray works, I will use it in our project later.

Superskyyy commented 2 years ago

Good. thanks.

Superskyyy commented 2 years ago

@Superskyyy In every code base, it is always better to have CI to check the things you mentioned. e2e is always being added once the basic APIs are there.

Yes I'll add those soon, linters are ready at my local.