search

SkyAPM / cpp2sky

Distributed tracing and monitor SDK in CPP for Apache SkyWalking APM
https://skywalking.apache.org
Apache License 2.0
58 stars 18 forks source link

refactor: refactor the grpc client to get better concurrency support and lifetime management #119

Closed wbpcode closed 11 months ago

wbpcode commented 1 year ago

See #116

wbpcode commented 1 year ago

There are some concurrency/lifetime problems in the previous impl. This is a refactor to the grpc client.

IT'S NOT READY FOR MERGE

wbpcode commented 1 year ago

cc @xlj would you mind help to do a quick review and test for this fix in your demo? I have no an accutally scene for the sky2cpp grpc client. 😞

xlj commented 1 year ago

@wbpcode It's

cc @xlj would you mind help to do a quick review and test for this fix in your demo? I have no an accutally scene for the sky2cpp grpc client. 😞

@wbpcode it's have "Segmentation fault" error.

wbpcode commented 1 year ago

@wbpcode It's

cc @xlj would you mind help to do a quick review and test for this fix in your demo? I have no an accutally scene for the sky2cpp grpc client. 😞

@wbpcode it's have "Segmentation fault" error.

Thanks for you help. Could you provider you test code, then I can try it in my local env? Thanks again.

xlj commented 1 year ago

@wbpcode It's

cc @xlj would you mind help to do a quick review and test for this fix in your demo? I have no an accutally scene for the sky2cpp grpc client. 😞

@wbpcode it's have "Segmentation fault" error.

Thanks for you help. Could you provider you test code, then I can try it in my local env? Thanks again.

https://github.com/SkyAPM/cpp2sky/issues/116
i pasted my test code in this bug description。

jackxuqq commented 5 months ago

@wbpcode It's

cc @xlj would you mind help to do a quick review and test for this fix in your demo? I have no an accutally scene for the sky2cpp grpc client. 😞

@wbpcode it's have "Segmentation fault" error.

Thanks for you help. Could you provider you test code, then I can try it in my local env? Thanks again.

116 i pasted my test code in this bug description。

@wbpcode It's

cc @xlj would you mind help to do a quick review and test for this fix in your demo? I have no an accutally scene for the sky2cpp grpc client. 😞

@wbpcode it's have "Segmentation fault" error.

Thanks for you help. Could you provider you test code, then I can try it in my local env? Thanks again.

116 i pasted my test code in this bug description。

What's the latest update on