kezhenxu94
commented
3 years ago Also, the existing license headers are the one specific to ASF projects, so we'd better fix them
Closed fgksgf closed 3 years ago
kezhenxu94
commented
3 years ago Also, the existing license headers are the one specific to ASF projects, so we'd better fix them
codecov-commenter
commented
3 years ago Merging #106 (4ac4d19) into master (9cca3cc) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #106 +/- ##
=======================================
Coverage 65.95% 65.95%
=======================================
Files 15 15
Lines 702 702
=======================================
Hits 463 463
Misses 195 195
Partials 44 44 | Impacted Files | Coverage Δ | |
|---|---|---|
| config_discovery.go | 88.88% <ø> (ø) |
|
| correlation.go | 87.50% <ø> (ø) |
|
| internal/idgen/idgen.go | 0.00% <ø> (ø) |
|
| noop.go | 66.66% <ø> (ø) |
|
| plugins/http/client.go | 48.78% <ø> (ø) |
|
| plugins/http/server.go | 50.00% <ø> (ø) |
|
| propagation/propagation.go | 50.53% <ø> (ø) |
|
| reporter/grpc.go | 54.35% <ø> (ø) |
|
| reporter/log.go | 0.00% <ø> (ø) |
|
| sampler.go | 67.64% <ø> (ø) |
|
| ... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 9cca3cc...4ac4d19. Read the comment docs.
wu-sheng
commented
3 years ago License Expected — Waiting for status to be reported
Pending check is missing. I think you need to keep it or update .asf.yml first in another PR.
kezhenxu94
commented
3 years ago License Expected — Waiting for status to be reported
Pending check is missing. I think you need to keep it or update .asf.yml first in another PR.
This is not ASF project so we don't have .asf.yml 😉 Just remove that require
Introduce apache/skywalking-eyes to check the license header.