search

SkyAPM / go2sky

Distributed tracing and monitor SDK in Go for Apache SkyWalking APM
https://skywalking.apache.org/
Apache License 2.0
447 stars 122 forks source link

fix: RandomSampler may get sampled when samplingRate is 0 #119

Closed kagaya85 closed 3 years ago

kagaya85 commented 3 years ago

fix #101

codecov-commenter commented 3 years ago

Codecov Report

Merging #119 (b31d1a0) into master (4af380c) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   67.48%   67.48%           
=======================================
  Files          17       17           
  Lines         735      735           
=======================================
  Hits          496      496           
  Misses        195      195           
  Partials       44       44
Impacted Files Coverage Δ
sampler.go 67.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4af380c...b31d1a0. Read the comment docs.