SkyAPM / go2sky

Distributed tracing and monitor SDK in Go for Apache SkyWalking APM
https://skywalking.apache.org/
Apache License 2.0
447 stars 122 forks source link

Plugin test based on skywalking-infra-e2e #122

Closed arugal closed 3 years ago

codecov-commenter commented 3 years ago

Codecov Report

Merging #122 (51ad7e1) into master (8c3683b) will increase coverage by 1.85%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   67.48%   69.33%   +1.85%     
==========================================
  Files          17       17              
  Lines         735      887     +152     
==========================================
+ Hits          496      615     +119     
- Misses        195      224      +29     
- Partials       44       48       +4     
Impacted Files Coverage Δ
plugins/http/server.go 46.15% <0.00%> (-3.85%) :arrow_down:
plugins/http/client.go 45.83% <0.00%> (-2.95%) :arrow_down:
span.go 100.00% <0.00%> (ø)
span_opts.go 100.00% <0.00%> (ø)
trace_data.go 100.00% <0.00%> (ø)
trace_opts.go 75.00% <0.00%> (ø)
log/context.go 100.00% <0.00%> (ø)
reporter/log.go 0.00% <0.00%> (ø)
internal/idgen/idgen.go 0.00% <0.00%> (ø)
correlation.go 88.57% <0.00%> (+1.07%) :arrow_up:
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c3683b...51ad7e1. Read the comment docs.

arugal commented 3 years ago

image The plugin test based on skywalking-infra-e2e was successfully run, and I will complete the verify part later.

@dmsolr @wu-sheng I need to build a skywalking-agent-test-tool image :)

arugal commented 3 years ago

@mrproliu @wu-sheng @kezhenxu94 Please review :)

CC @kagaya85 we tested the plugin via skywalking-infra-e2e

arugal commented 3 years ago

@wu-sheng @mrproliu please review

wu-sheng commented 3 years ago

@arugal @kezhenxu94 @mrproliu Once we have several more e2e tests by using this tool, it is time to discuss its version number and run a release. Then we should write 1-2 blogs about how it works, and how other projects could adopt it.