SkyAPM / go2sky

Distributed tracing and monitor SDK in Go for Apache SkyWalking APM
https://skywalking.apache.org/
Apache License 2.0
448 stars 122 forks source link

feat: add kafka reporter without cds #128

Closed matianjun1 closed 2 years ago

matianjun1 commented 2 years ago

add kafka reporter just like SkyWalking Python Agent implement

arugal commented 2 years ago

Hi @matianjun1 Please check the test first , and I think a kafka-reporter E2E test should be added, using skywalking-infra-e2e.

arugal commented 2 years ago

The kafka-reporter dependence on Shopify/sarama, if submit code to go2sky-plugins, go2sky can still maintain less dependence, what do you think? @wu-sheng @matianjun1 @dmsolr

wu-sheng commented 2 years ago

Make sense to me. SkyWalking Kafka reporter for Java is in the reporter plugin list too.

dmsolr commented 2 years ago

Make sense.

wu-sheng commented 2 years ago

@matianjun1 Please follow the recommendation.