SkyAPM / go2sky

Distributed tracing and monitor SDK in Go for Apache SkyWalking APM
https://skywalking.apache.org/
Apache License 2.0
448 stars 122 forks source link

Grpc Reporter's logger cannot use custom logger. #138

Closed legenove closed 2 years ago

legenove commented 2 years ago

The gRPCReporter struct's logger is *log.Logger. User must use *log.Logger. Bug some logger middleware can‘t convert to *log.Logger. It is recommended to use an interface here, like:

type Logger interface {
    Printf(format string, v ...interface{})
}

type gRPCReporter struct {
    ...
    logger           Logger
    ...
}