Closed arugal closed 2 years ago
Merging #147 (3848d35) into master (a12c5be) will increase coverage by
0.09%
. The diff coverage is35.71%
.:exclamation: Current head 3848d35 differs from pull request most recent head 40f8f27. Consider uploading reports for the commit 40f8f27 to get more accurate results
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
+ Coverage 70.64% 70.73% +0.09%
==========================================
Files 18 18
Lines 930 933 +3
==========================================
+ Hits 657 660 +3
Misses 225 225
Partials 48 48
Impacted Files | Coverage Δ | |
---|---|---|
reporter/grpc.go | 56.14% <35.71%> (+0.58%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a12c5be...40f8f27. Read the comment docs.
Could you introduce what is this? I can't see the update in readme doc.
Could you introduce what is this? I can't see the update in readme doc.
Description has been added for this PR
Background
Now GRPCReporter can only use log.Logger to output logs, but there are many good log libraries, such as zap, logrus, I think we should design a logging interface and let the user decide which one to use.
Design
Use Case