Any plans for plugin to integrate with go-resty?

SkyAPM / go2sky

Distributed tracing and monitor SDK in Go for Apache SkyWalking APM

https://skywalking.apache.org/

Apache License 2.0

448 stars 122 forks source link

Any plans for plugin to integrate with go-resty? #42

Closed clannadxr closed 4 years ago

clannadxr commented 4 years ago

I am using go-resty/resty as http client. The plugin http provided now can not be integrated with resty.

I noticed that it's convenient to integrate using the resty middleware(OnBeforeRequest、OnAfterResponse). So do you have any plans for a plugin with go-resty?

wu-sheng commented 4 years ago

Contribution is welcome. You could use our APIs to implement this plugin.

clannadxr commented 4 years ago

Sorry, resty has NewWithClient API which can pass *http.Client in, so the plugins/http has already meet my need. It seems there's no need for a new plugin.

wu-sheng commented 4 years ago

@clannadxr If you want, I think it is better you could submit a pull request to add a markdown document to show the demo, and linked at here, https://github.com/SkyAPM/go2sky#plugins