search

SkyAPM / go2sky

Distributed tracing and monitor SDK in Go for Apache SkyWalking APM
https://skywalking.apache.org/
Apache License 2.0
448 stars 122 forks source link

Adapter mosn #49

Closed arugal closed 4 years ago

arugal commented 4 years ago

Provide a least-dependent version of go2sky for mosn.

wu-sheng commented 4 years ago

Set a different milestone for mosn release too.

arugal commented 4 years ago

FYI @taoyuanyuan @rootsongjc

wu-sheng commented 4 years ago

One question, the new milestone named as 0.4.0-mosn. AFAIK, there is no go2sky 0.4.0.

The go2sky-mosn release should be a fork release, especially for MOSN. We should keep the versioin as 0.3.0-mosn. The only change in the mosn branch should be grpc downgrade.

Please correct me if I am wrong.

arugal commented 4 years ago

One question, the new milestone named as 0.4.0-mosn. AFAIK, there is no go2sky 0.4.0. The go2sky-mosn release should be a fork release, especially for MOSN. We should keep the versioin as 0.3.0-mosn.

I will modify the milestone.

The only change in the mosn branch should be grpc downgrade.

Let me try.

wu-sheng commented 4 years ago

The only change in the mosn branch should be grpc downgrade. Let me try.

It is fine if you need to release 0.4.0 on the master branch. My point is only, don't make too much change in the mosn branch. It will be. very hard to maintain.

arugal commented 4 years ago

@wu-sheng I have reversed the extra changes, please review :)