SkyAPM / go2sky

Distributed tracing and monitor SDK in Go for Apache SkyWalking APM
https://skywalking.apache.org/
Apache License 2.0
448 stars 122 forks source link

Adapt the new v3 protocol #53

Closed arugal closed 4 years ago

arugal commented 4 years ago

Follow the new v3 protocol.

arugal commented 4 years ago

Screenshots

Service

image

Endpoint

image

image

Instance

image

Topo

image

Trace

image

image

codecov-io commented 4 years ago

Codecov Report

Merging #53 into master will increase coverage by 2.64%. The diff coverage is 70.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   67.26%   69.91%   +2.64%     
==========================================
  Files          11       14       +3     
  Lines         666      668       +2     
==========================================
+ Hits          448      467      +19     
+ Misses        185      160      -25     
- Partials       33       41       +8     
Impacted Files Coverage Δ
internal/idgen/idgen.go 0.00% <0.00%> (ø)
reporter/log.go 0.00% <0.00%> (ø)
plugins/http/client.go 45.83% <50.00%> (ø)
plugins/http/go_resty.go 60.00% <60.00%> (ø)
plugins/http/server.go 46.15% <60.00%> (+0.15%) :arrow_up:
segment.go 92.59% <61.90%> (+12.01%) :arrow_up:
reporter/grpc.go 61.11% <71.96%> (+1.90%) :arrow_up:
propagation/propagation.go 66.03% <79.16%> (ø)
trace.go 83.33% <88.88%> (+0.11%) :arrow_up:
noop.go 85.71% <100.00%> (+28.57%) :arrow_up:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be06e8d...fa3b23c. Read the comment docs.

wu-sheng commented 4 years ago

Do We expect coverage rate decrease 10%?

arugal commented 4 years ago

Do We expect coverage rate decrease 10%?

Let me update the unit test.

wu-sheng commented 4 years ago

Seems no coverage change?

arugal commented 4 years ago

Seems no coverage change?

Please review :)