Please do not delete releases or tags

SkyAPM / go2sky

Distributed tracing and monitor SDK in Go for Apache SkyWalking APM

https://skywalking.apache.org/

Apache License 2.0

448 stars 122 forks source link

Please do not delete releases or tags #57

Closed cch123 closed 4 years ago

cch123 commented 4 years ago

Describe the bug When user depends on your library, they may not vendor it. If a tag or a release was removed, then go build will fail.

To Reproduce go.mod:

module whatever.com/ccc

go 1.12

require (
        github.com/SkyAPM/go2sky v0.3.1-0.20200329092408-8b3e4d536d8d
)

Expected behavior go build success

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Version [e.g. 22]

Additional context Add any other context about the problem here.

wu-sheng commented 4 years ago

0.3.1? @arugal When did we release this?

wu-sheng commented 4 years ago

@arugal I received DM from MOSN community too, seems you used the wrong tag somehow? The 0.3.0-mosn should be tag name. Could you fix this on our repo and MOSN repo ASAP?

arugal commented 4 years ago

Hi @cch123

Thank you for your feedback. Do you mean that if I delete the branch or tag of go2sky, it will cause potential problems?

cch123 commented 4 years ago

@arugal , yes~

arugal commented 4 years ago

@cch123 golang solution should be vendor, mosn does the same thing.

Please let me know if I'm wrong :)

@wu-sheng release a new tag won't solve it. Anyway, I will finish it as soon as possible.

cch123 commented 4 years ago

After investigation, this is a goproxy cache issue, sorry for misunderstanding...

wu-sheng commented 4 years ago

Thank you all for quick clarification.