search

SkyAPM / go2sky

Distributed tracing and monitor SDK in Go for Apache SkyWalking APM
https://skywalking.apache.org/
Apache License 2.0
448 stars 122 forks source link

gin plugin bugfixed in master, but it still exists in v0.3.0, release a new version? #58

Closed Logic0 closed 4 years ago

Logic0 commented 4 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like A clear and concise description of what you want to happen. using this still import the version with bug: import "github.com/SkyAPM/go2sky/plugins/gin"

found the bug was fixed 2 months ago, the code(in plugin/gin.go): from operationName: c.Request.Host + c.Request.URL.Path, to operationName: fmt.Sprintf("/%s%s", r.Method, r.Path),

release a new version?

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

wu-sheng commented 4 years ago

The new release will follow the main repo 8.0.0 release, because v3 protocol is required.