routeMap key is handler name, if different url paths route to same handler, only the last one is available to trace, consider using Method+Path as the key?

[Logic0]

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

routeMap key is handler name, if different url paths route to same handler, only the last one is available to trace, consider using Path as the key to solve this? or any other solutions?

mm[r.Handler] = routeInfo{ operationName: fmt.Sprintf("/%s%s", r.Method, r.Path), }

described situation can be avoided by using different handlers for different urls, but it takes time to find why when it happens.

Additional context Add any other context or screenshots about the feature request here.

[arugal]

Hi @Logic0 Glad to receive your feedback. I don't quite understand what you said. Could you give me an example :)

[Logic0]

if we have a handler like: func doSomething( c *gin.Context ) {...}

then register 2 handler:

eg = gin.New()
eg.Use( Middleware(eg, tracer) )
eg.POST( "/api/v1/m1", doSomething )
eg.POST( "/api/v1/m2", doSomething )

according to the code in go2sky gin plugin: mm[r.Handler] = routeInfo{ operationName: fmt.Sprintf("/%s%s", r.Method, r.Path), }

the mm will be:

mm['doSomething'] = "/POST/api/v1/m1"         // will be overwrited by m2
mm['doSomething'] = "/POST/api/v1/m2"

all the request from "/POST/api/v1/m1" will be recognized as "/POST/api/v1/m2", as it's overwrited.

hope this helps.

[arugal]

Thank you. It does happen. Let me see how to solve it.

[arugal]

Hi @Logic0, If use http.Request.Method + http.Request.URL.Path as the operation name, so /user/:name will generate multiple operation name, I will keep the current solution until there is a better solution.

[wu-sheng]

We did a discussion, this should be plugin FAQ.

[wu-sheng]

@Logic0 As you have known the logic behind this, I recommend using a method wrapper to make this conflict gone. I have talked with @arugal, my suggestion would like to add a FAQ document with an example.

[arugal]

Hi @Logic0 https://github.com/SkyAPM/go2sky-plugins/tree/master/gin/v3 We provide a new version, welcome to use.